fix(google-maps): allow ground overlay bounds to be changed #20873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
jelbourn
reviewed
Oct 26, 2020
Allows for the bounds of the Google Maps ground overlay to be changed after initialization. This case is different from other similar components, because Google Maps doesn't provide an API to change the bounds so we have to recreate the overlay any time they change. Fixes angular#20865.
crisbeto
force-pushed
the
20865/ground-overlay-bounds-change
branch
from
034e0b5 to
28d5a46
Compare
mbehrlich
reviewed
Oct 26, 2020
mbehrlich
reviewed
Oct 26, 2020
mbehrlich
reviewed
Oct 26, 2020
crisbeto
added
blocked
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 27, 2020
This came up during the review of angular#20873. Currently the class that manages events for the Google Maps objects assumes that once a target is assigned, it'll either be maintained or eventually removed which means that the fix from angular#20873 will cause any existing event listeners to be dropped. These changes add some code which will preserve the listeners. Furthermore, I've added a dedicated testing setup for the `MapEventManager` since there's a fair bit of logic encapsulated in it and we've only been testing it by proxy through the various Google Maps components.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 27, 2020
This came up during the review of angular#20873. Currently the class that manages events for the Google Maps objects assumes that once a target is assigned, it'll either be maintained or eventually removed which means that the fix from angular#20873 will cause any existing event listeners to be dropped. These changes add some code which will preserve the listeners. Furthermore, I've added a dedicated testing setup for the `MapEventManager` since there's a fair bit of logic encapsulated in it and we've only been testing it by proxy through the various Google Maps components.
wagnermaciel
pushed a commit
that referenced
this pull request
Oct 28, 2020
This came up during the review of #20873. Currently the class that manages events for the Google Maps objects assumes that once a target is assigned, it'll either be maintained or eventually removed which means that the fix from #20873 will cause any existing event listeners to be dropped. These changes add some code which will preserve the listeners. Furthermore, I've added a dedicated testing setup for the `MapEventManager` since there's a fair bit of logic encapsulated in it and we've only been testing it by proxy through the various Google Maps components. (cherry picked from commit cc503c4)
wagnermaciel
pushed a commit
that referenced
this pull request
Oct 28, 2020
This came up during the review of #20873. Currently the class that manages events for the Google Maps objects assumes that once a target is assigned, it'll either be maintained or eventually removed which means that the fix from #20873 will cause any existing event listeners to be dropped. These changes add some code which will preserve the listeners. Furthermore, I've added a dedicated testing setup for the `MapEventManager` since there's a fair bit of logic encapsulated in it and we've only been testing it by proxy through the various Google Maps components.
wagnermaciel
pushed a commit
that referenced
this pull request
Oct 28, 2020
This came up during the review of #20873. Currently the class that manages events for the Google Maps objects assumes that once a target is assigned, it'll either be maintained or eventually removed which means that the fix from #20873 will cause any existing event listeners to be dropped. These changes add some code which will preserve the listeners. Furthermore, I've added a dedicated testing setup for the `MapEventManager` since there's a fair bit of logic encapsulated in it and we've only been testing it by proxy through the various Google Maps components. (cherry picked from commit cc503c4)
crisbeto
added
action: merge
|
Unblocking now that #20897 has been merged. |
annieyw
pushed a commit
that referenced
this pull request
Nov 3, 2020
Allows for the bounds of the Google Maps ground overlay to be changed after initialization. This case is different from other similar components, because Google Maps doesn't provide an API to change the bounds so we have to recreate the overlay any time they change. Fixes #20865. (cherry picked from commit f7023c8)
annieyw
pushed a commit
that referenced
this pull request
Nov 3, 2020
Allows for the bounds of the Google Maps ground overlay to be changed after initialization. This case is different from other similar components, because Google Maps doesn't provide an API to change the bounds so we have to recreate the overlay any time they change. Fixes #20865. (cherry picked from commit f7023c8)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the bounds of the Google Maps ground overlay to be changed after initialization. This case is different from other similar components, because Google Maps doesn't provide an API to change the bounds so we have to recreate the overlay any time they change.
Fixes #20865.