refactor(material/core): remove underscores from symbols consumed in other files #20906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
private-sass-refactor
branch
3 times, most recently
from
a0d758d to
8871c76
Compare
crisbeto
changed the title
crisbeto
added
P2
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn,
mmalerba and
a team
as code owners
crisbeto
force-pushed
the
private-sass-refactor
branch
from
8871c76 to
368ab08
Compare
crisbeto
changed the title
crisbeto
force-pushed
the
private-sass-refactor
branch
from
368ab08 to
f7d22f4
Compare
crisbeto
changed the title
crisbeto
changed the title
crisbeto
force-pushed
the
private-sass-refactor
branch
from
f7d22f4 to
160ac77
Compare
crisbeto
force-pushed
the
private-sass-refactor
branch
from
160ac77 to
278a2a8
Compare
…other files In the new Sass module system a symbol prefixed with an underscore means that it's private and it can't be used in other files. These changes refactor all of our existing usages to remove the underscore. Some of the symbols have been moved into `private` directories to make it more obvious that they shouldn't be depended upon.
crisbeto
force-pushed
the
private-sass-refactor
branch
from
278a2a8 to
4b07882
Compare
annieyw
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new Sass module system a symbol prefixed with an underscore means that it's private and it can't be used in other files. These changes refactor all of our existing usages to remove the underscore. Some of the symbols have been moved into
privatedirectories to make it more obvious that they shouldn't be depended upon.Note: setting as a P2, because it's blocking work on the Sass module migration.