Skip to content

feat(material/radio): allow focus origin to be optional input in focus method #20911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

jesscxu
Copy link
Contributor

@jesscxu jesscxu commented Oct 28, 2020

WHAT: For Angular Material components that have a focus() method, allow for the origin param to be optional and remove the default origin value.

WHY: For cases where the focus() method is called and the origin is already defined, we don’t want to override the origin using focusVia to always be some default value. In many cases, we want to leave the origin unchanged, but if there are cases that need the origin to be updated, allow for this with an optional origin param.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 28, 2020
@jesscxu jesscxu force-pushed the remove-default-origin-radio-focus branch 2 times, most recently from b76d68a to b9f786b Compare October 28, 2020 21:07
@mmalerba mmalerba self-requested a review October 28, 2020 22:20
@jesscxu jesscxu force-pushed the remove-default-origin-radio-focus branch from b9f786b to fcd360e Compare November 2, 2020 22:34
@jelbourn
Copy link
Member

jelbourn commented Nov 4, 2020

Would this change also need to apply to the MDC-based radio button?

@jesscxu
Copy link
Contributor Author

jesscxu commented Nov 5, 2020

@jelbourn It should already be applied because the focus() method I am updating is in the class _MatRadioButtonBase and MDC-based radio button extends this class. This change should apply to both MDC and non-MDC radios.

@annieyw annieyw added G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Nov 5, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Nov 5, 2020
@annieyw annieyw merged commit e303245 into angular:master Nov 6, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants