Skip to content

docs(material/chips): add chips harness example #20942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Oct 30, 2020

No description provided.

@annieyw annieyw requested a review from andrewseguin as a code owner October 30, 2020 20:20
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 30, 2020
@annieyw annieyw requested review from jelbourn and mmalerba October 30, 2020 20:20
@annieyw annieyw force-pushed the more-examples branch 2 times, most recently from 4fe6c5f to 7bc9531 Compare October 30, 2020 20:56
);

it('should get whether a chip list is disabled', async () => {
const chipLists = await loader.getAllHarnesses(MatChipListHarness);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're only testing the first list, you can use loader.getHarness instead. It'll help you avoid repeating [0] below. The same goes for the other tests that only look for one instance.

@annieyw annieyw closed this Nov 9, 2020
@annieyw annieyw deleted the more-examples branch November 9, 2020 19:41
@annieyw annieyw restored the more-examples branch November 9, 2020 20:26
@annieyw annieyw reopened this Nov 9, 2020
@annieyw annieyw added merge safe target: patch This PR is targeted for the next patch release labels Nov 9, 2020
@annieyw
Copy link
Contributor Author

annieyw commented Nov 9, 2020

Changed to using loader.getHarness when just getting 1 instance.

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 9, 2020
@mmalerba mmalerba merged commit 554c775 into angular:master Nov 12, 2020
mmalerba pushed a commit that referenced this pull request Nov 12, 2020
@annieyw annieyw deleted the more-examples branch November 12, 2020 18:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants