Skip to content

fix(material/checkbox): set display on host node #20961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2020
Merged

fix(material/checkbox): set display on host node #20961

merged 1 commit into from
Nov 6, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 3, 2020

Currently the host nodes are display: inline by default which doesn't allow for things like margin and width to be set. These changes switch to inline-block which is a bit more flexible.

Fixes #20954.

@crisbeto
fix(material/checkbox): set display on host node
9e89958 
Currently the host nodes are `display: inline` by default which doesn't allow for
things like `margin` and `width` to be set. These changes switch to `inline-block` which
is a bit more flexible.

Fixes angular#20954.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 3, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 3, 2020
@crisbeto crisbeto added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Nov 3, 2020
@crisbeto
Copy link
Member Author

crisbeto commented Nov 3, 2020

Caretaker note: this has the potential to change people's layouts. If it does end up breaking somebody, we should consider applying the change only to the MDC checkbox.

jelbourn
jelbourn approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Nov 3, 2020
@annieyw annieyw merged commit d686290 into angular:master Nov 6, 2020
annieyw pushed a commit that referenced this pull request Nov 6, 2020
@crisbeto @annieyw
fix(material/checkbox): set display on host node (#20961)
e00d340 
Currently the host nodes are `display: inline` by default which doesn't allow for
things like `margin` and `width` to be set. These changes switch to `inline-block` which
is a bit more flexible.

Fixes #20954.

(cherry picked from commit d686290)
annieyw pushed a commit that referenced this pull request Nov 6, 2020
@crisbeto @annieyw
fix(material/checkbox): set display on host node (#20961)
d868717 
Currently the host nodes are `display: inline` by default which doesn't allow for
things like `margin` and `width` to be set. These changes switch to `inline-block` which
is a bit more flexible.

Fixes #20954.

(cherry picked from commit d686290)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatCheckbox should be display: inline-block
4 participants
@crisbeto @jelbourn @mmalerba @annieyw