Skip to content

build: update to latest scss bundler and resolve file size issue #21016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2020
Merged

build: update to latest scss bundler and resolve file size issue #21016

merged 1 commit into from
Nov 12, 2020

Conversation

crisbeto
Copy link
Member

Updates to the latest version of scss-bundle and resolves an issue that was causing the theming bundle to be more than 15mb.

@crisbeto
build: update to latest scss bundler and resolve file size issue
1820790 
Updates to the latest version of `scss-bundle` and resolves an issue that was causing
the theming bundle to be more than 15mb.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Nov 11, 2020
@crisbeto crisbeto requested review from jelbourn and a team as code owners November 11, 2020 19:23
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 11, 2020
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 11, 2020
mmalerba
mmalerba approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jelbourn
jelbourn approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 7ca2af0 into angular:master Nov 12, 2020
mmalerba pushed a commit that referenced this pull request Nov 12, 2020
@crisbeto @mmalerba
build: update to latest scss bundler and resolve file size issue (#21016
8f0dc3a 
)

Updates to the latest version of `scss-bundle` and resolves an issue that was causing
the theming bundle to be more than 15mb.

(cherry picked from commit 7ca2af0)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @mmalerba