fix(material-experimental/mdc-chips): align test harnesses with the non-MDC version #21051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
crisbeto
added
the
merge: caretaker note
|
Caretaker note: I've had to make a few breaking changes to public APIs in order to align them with the non-MDC versions. The changes aren't going through the same breaking change process, because they're still under |
mmalerba
reviewed
Nov 16, 2020
src/material-experimental/mdc-chips/testing/chip-harness.spec.ts
Outdated
Show resolved
Hide resolved
src/material-experimental/mdc-chips/testing/chip-listbox-harness.spec.ts
Outdated
Show resolved
Hide resolved
src/material-experimental/mdc-chips/testing/chip-listbox-harness.ts
Outdated
Show resolved
Hide resolved
…on-MDC version Aligns the test harnesses of the MDC-based chips module with the ones from the non-MDC version. Overview of the changes: * `MatChipGridHarness` - `getTextInput` was renamed to `getInput` to match the non-MDC list harness. Also adds a few utility methods to check whether the grid is disabled, required etc. * `MatChipHarness` - adds support for the same set of filters when querying for the harness. Also adds a method to get the removal button and disabled state. * `MatChipInputHarness` - adds a bunch of utility methods that we have on the other input-related harnesses. Also implemets the same set of harness filters as the non-MDC harness. * `MatChipListboxHarness` - Renames `getOptions` to `getChips` for consistency and removes the `getSelected` method in favor of filtering selected chips through the harness predicate. Also adds some utility methods for selecting chips, getting the disabled and required states etc. * `MatChipOptionHarness` - implements harness filters and adds APIs for selecting/deselecting. * `MatChipRemoveHarness` - new harness which is identical to the non-MDC `MatChipRemoveHarness`. * `MatChipSetHarness` - supports filtering through the `getChips` method. These changes also include tests for all the new functionality and minor cleanups around the `mdc-chips/testing` package.
crisbeto
force-pushed
the
mdc-chips-consoldation
branch
from
432d365 to
69c4610
Compare
|
The feedback has been addressed. |
wagnermaciel
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns the test harnesses of the MDC-based chips module with the ones from the non-MDC version. Overview of the changes:
MatChipGridHarness-getTextInputwas renamed togetInputto match the non-MDC list harness. Also adds a few utility methods to check whether the grid is disabled, required etc.MatChipHarness- adds support for the same set of filters when querying for the harness. Also adds a method to get the removal button and disabled state.MatChipInputHarness- adds a bunch of utility methods that we have on the other input-related harnesses. Also implemets the same set of harness filters as the non-MDC harness.MatChipListboxHarness- RenamesgetOptionstogetChipsfor consistency and removes thegetSelectedmethod in favor of filtering selected chips through the harness predicate. Also adds some utility methods for selecting chips, getting the disabled and required states etc.MatChipOptionHarness- implements harness filters and adds APIs for selecting/deselecting.MatChipRemoveHarness- new harness which is identical to the non-MDCMatChipRemoveHarness.MatChipSetHarness- supports filtering through thegetChipsmethod.These changes also include tests for all the new functionality and minor cleanups around the
mdc-chips/testingpackage.