perf(cdk/testing): reduce change detections when running parallel actions #21071
Conversation
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
testing-parallel
branch
from
98e78d7 to
33df7f9
Compare
crisbeto
added
the
merge: caretaker note
|
Caretaker note: these changes touch pretty much all test harnesses so it's possible that something could break during the presubmit. If something does break, I'll split this up into individual PRs. |
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn,
mmalerba and
a team
as code owners
crisbeto
added
P2
…ions Switches all of our `testing` code to use `parallel` instead of `Promise.all` which reduces the number of change detections that we'll trigger during tests. Also adds more type overloads to `parallel`, because the previous types didn't allow the `values` function to return mixed value arrays which we had in ~15 instances. I've tried to reduce the amount of code by only implementing up to 5 overloads, but we may want to expand it to 9 like `Promise.all`.
crisbeto
force-pushed
the
testing-parallel
branch
from
33df7f9 to
36133df
Compare
| * @param values A getter for the async values to resolve in parallel with batched change detection. | ||
| * @return The resolved values. | ||
| */ | ||
| export function parallel<T1, T2, T3, T4, T5>( |
There was a problem hiding this comment.
Oh good catch, is there some way to do this without having a separate declaration for each number of params?
This is what I get for putting off actually using the function in our own tests 😞
There was a problem hiding this comment.
There isn't. I took this from TS's built-in type for Promise.all and I've seen rxjs do something similar.
mmalerba
added
action: merge
|
Changed to minor due to the new method signatures |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Switches all of our
testingcode to useparallelinstead ofPromise.allwhich reduces the number of change detections that we'll trigger during tests.Also adds more type overloads to
parallel, because the previous types didn't allow thevaluesfunction to return mixed value arrays which we had in ~15 instances. I've tried to reduce the amount of code by only implementing up to 5 overloads, but we may want to expand it to 9 likePromise.all.