docs(material/tooltip): add harness example for tooltip #21083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annieyw
added
P3
google-cla
bot
added
the
cla: yes
annieyw
added
merge safe
target: patch
crisbeto
reviewed
Nov 19, 2020
| ); | ||
|
|
||
| it('should load all tooltip harnesses', async () => { | ||
| if (!isSupported) { |
There was a problem hiding this comment.
I think that we should remove these checks from the harness examples. We need it in our own tests, because we run them against iOS and Android device, but most people won't be doing it. It was also a limitation that we should be able to work around now.
fixup! remove platform check
wagnermaciel
pushed a commit
that referenced
this pull request
Nov 19, 2020
fixup! remove platform check (cherry picked from commit 5ab55fc)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.