Skip to content

fix(material-experimental/mdc-form-field): add padding to subscript t… #21265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

fix(material-experimental/mdc-form-field): add padding to subscript t… #21265

merged 1 commit into from
Dec 17, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Dec 10, 2020

…o align with spec

There should be 16px padding between the the edge of the form field box and start of the hint/error.
https://material.io/components/text-fields#specs

Before:
54VdYuytKZFrzXT

After:
4vAJ9fnk4JbURnL

@annieyw annieyw added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Dec 10, 2020
@annieyw annieyw requested review from jelbourn and mmalerba December 10, 2020 01:06
@annieyw annieyw requested a review from devversion as a code owner December 10, 2020 01:06
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 10, 2020
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Dec 10, 2020
mmalerba
mmalerba approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Dec 17, 2020
@mmalerba mmalerba merged commit eb32025 into angular:master Dec 17, 2020
@annieyw annieyw deleted the subscript-align branch December 18, 2020 08:14
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
@annieyw @wagnermaciel
fix(material-experimental/mdc-form-field): add padding to subscript t…
2b26379 
…o align with spec (angular#21265)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annieyw @jelbourn @mmalerba