fix(cdk/scrolling): virtual scroll not picking up trackBy function when items come in after init #21335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
commented
Dec 12, 2020
| @Input() items = Array(10).fill(0).map((_, i) => i); | ||
| @Input() trackBy: TrackByFunction<number>; | ||
| @Input() templateCacheSize = 20; | ||
| orientation = 'vertical'; |
There was a problem hiding this comment.
Removing the Input here isn't necessary for the fix, but I noticed that they don't actually do anything.
crisbeto
changed the title
…en items come in after init The virtual scroll only creates its `IterableDiffer` once, which means that if the `trackBy` function comes in at a later point (e.g. the input changed or the initialization order is different), it won't be picked up. These changes make it so the differ always has a `trackBy` which then delegates to the user-provided one or falls back to the default. Fixes angular#21281.
crisbeto
force-pushed
the
21281/track-by-delayed
branch
from
a815ad9 to
709691d
Compare
mmalerba
pushed a commit
that referenced
this pull request
Dec 17, 2020
…en items come in after init (#21335) The virtual scroll only creates its `IterableDiffer` once, which means that if the `trackBy` function comes in at a later point (e.g. the input changed or the initialization order is different), it won't be picked up. These changes make it so the differ always has a `trackBy` which then delegates to the user-provided one or falls back to the default. Fixes #21281. (cherry picked from commit 43081d9)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…en items come in after init (angular#21335) The virtual scroll only creates its `IterableDiffer` once, which means that if the `trackBy` function comes in at a later point (e.g. the input changed or the initialization order is different), it won't be picked up. These changes make it so the differ always has a `trackBy` which then delegates to the user-provided one or falls back to the default. Fixes angular#21281.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The virtual scroll only creates its
IterableDifferonce, which means that if thetrackByfunction comes in at a later point (e.g. the input changed or the initialization order is different), it won't be picked up.These changes make it so the differ always has a
trackBywhich then delegates to the user-provided one or falls back to the default.Fixes #21281.