Skip to content

build: adjust browserstack version #21383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 17, 2020

Changes the Browserstack version in an attempt to fix the CI. Also switches back to Browserstack's default tunnel, rather than our custom one which appears to be timing out.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 17, 2020
@crisbeto crisbeto force-pushed the browserstack-bump branch 4 times, most recently from c8711fc to 6d564e1 Compare December 17, 2020 20:01
Changes the Browserstack version in an attempt to fix the CI.
@crisbeto crisbeto marked this pull request as ready for review December 17, 2020 20:18
@crisbeto crisbeto requested a review from a team as a code owner December 17, 2020 20:18
@crisbeto crisbeto added merge safe P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Dec 17, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Dec 17, 2020
@mmalerba mmalerba merged commit b8cdef4 into angular:master Dec 17, 2020
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 17, 2020
Changes the Browserstack version in an attempt to fix the CI.
mmalerba pushed a commit that referenced this pull request Dec 17, 2020
Changes the Browserstack version in an attempt to fix the CI.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
Changes the Browserstack version in an attempt to fix the CI.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants