Skip to content

refactor(material/datepicker): expose year view change detector ref #21499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2021
Merged

refactor(material/datepicker): expose year view change detector ref #21499

merged 1 commit into from
Jan 6, 2021

Conversation

MichaelJamesParsons
Copy link
Collaborator

Open up the mat year view's ChangeDetectorRef so it can be accessed by other components. This is necessary to align with an internal Google datepicker spec.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 5, 2021
@MichaelJamesParsons MichaelJamesParsons added area: material/datepicker G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround labels Jan 5, 2021
mmalerba
mmalerba approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 5, 2021
@annieyw annieyw added the target: patch This PR is targeted for the next patch release label Jan 6, 2021
@annieyw annieyw merged commit 74cd45a into angular:master Jan 6, 2021
annieyw pushed a commit that referenced this pull request Jan 6, 2021
@MichaelJamesParsons @annieyw
refactor(material/datepicker): expose year view change detector ref (#…
deb149c 
…21499)

(cherry picked from commit 74cd45a)
@MichaelJamesParsons MichaelJamesParsons deleted the datepicker-year-cdref branch January 6, 2021 17:23
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
@MichaelJamesParsons @wagnermaciel
refactor(material/datepicker): expose year view change detector ref (a…
5916cfc 
…ngular#21499)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: material/datepicker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelJamesParsons @mmalerba @annieyw