fix(material/dialog): content directives picking up wrong ref for stacked mixed type dialogs #21579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
dialog-stacked-ref
branch
from
97d0136 to
a6502df
Compare
crisbeto
force-pushed
the
dialog-stacked-ref
branch
from
a6502df to
8b7a29b
Compare
crisbeto
force-pushed
the
dialog-stacked-ref
branch
from
8b7a29b to
8eda82e
Compare
crisbeto
force-pushed
the
dialog-stacked-ref
branch
from
8eda82e to
08f36f7
Compare
crisbeto
force-pushed
the
dialog-stacked-ref
branch
from
08f36f7 to
e701706
Compare
devversion
previously approved these changes
Aug 18, 2021
andrewseguin
removed
the
cla: yes
googlebot
added
the
cla: yes
…cked mixed type dialogs The dialog content directives try to resolve their closest dialog using DI, and if it fails (e.g. inside a template dialog), they fall back to resolving it through the DOM. This becomes problematic if the `ng-template` was declared inside another dialog component, because it'll pick up the declaration dialog, not the one that the button exists in. These changes remove the resolution using DI and switch to only going through the DOM. Fixes angular#21554.
crisbeto
force-pushed
the
dialog-stacked-ref
branch
from
e701706 to
bf95d4a
Compare
|
I'll mark this as blocked for now. There should be a better way of doing it with injectors now. |
crisbeto
added
blocked
andrewseguin
added
needs rebase
and removed
P3
josephperrott
added
action: cleanup
josephperrott
requested review from
amysorto and
mmalerba
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dialog content directives try to resolve their closest dialog using DI, and if it fails (e.g. inside a template dialog), they fall back to resolving it through the DOM. This becomes problematic if the
ng-templatewas declared inside another dialog component, because it'll pick up the declaration dialog, not the one that the button exists in.These changes remove the resolution using DI and switch to only going through the DOM.
Fixes #21554.