Skip to content

docs: fix input text color to match theme in custom form guide #21750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2021
Merged

docs: fix input text color to match theme in custom form guide #21750

merged 1 commit into from
Feb 5, 2021

Conversation

Splaktar
Copy link
Contributor

  • without this, it's black on dark grey

Before

Screen Shot 2021-01-30 at 02 46 49

This knocks 2 points off of the LH a11y audit for the guide.

After

Screen Shot 2021-01-30 at 02 46 40

@Splaktar Splaktar added Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation area: material/form-field labels Jan 30, 2021
@Splaktar Splaktar self-assigned this Jan 30, 2021
@Splaktar Splaktar requested a review from jelbourn as a code owner January 30, 2021 07:48
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 30, 2021
@Splaktar Splaktar added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Jan 30, 2021
@Splaktar Splaktar mentioned this pull request Jan 30, 2021
Merged
jelbourn
jelbourn approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Feb 1, 2021
@annieyw annieyw merged commit e773f90 into angular:master Feb 5, 2021
annieyw pushed a commit that referenced this pull request Feb 5, 2021
@Splaktar @annieyw
docs: fix input text color to match theme in custom form guide (#21750)
936ecd6 
- without this, it's black on dark grey

(cherry picked from commit e773f90)
annieyw pushed a commit that referenced this pull request Feb 5, 2021
@Splaktar @annieyw
docs: fix input text color to match theme in custom form guide (#21750)
3e4b6bc 
- without this, it's black on dark grey

(cherry picked from commit e773f90)
@Splaktar Splaktar deleted the fix-custom-form-control-guide-dark-mode branch February 5, 2021 14:59
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@Splaktar @wagnermaciel
docs: fix input text color to match theme in custom form guide (angul…
7d84bc8 
…ar#21750)

- without this, it's black on dark grey
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@Splaktar @wagnermaciel
docs: fix input text color to match theme in custom form guide (angul…
584ecc9 
…ar#21750)

- without this, it's black on dark grey
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@Splaktar Splaktar

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/form-field cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Splaktar @jelbourn @annieyw