Skip to content

build: resolve circular dependencies in e2e code #21812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 4, 2021

Moves an interface in order to resolve a circular dependency.

@crisbeto crisbeto added merge safe P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Feb 4, 2021
@crisbeto crisbeto requested review from devversion, mmalerba and a team as code owners February 4, 2021 22:02
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 4, 2021
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Moves an interface in order to resolve a circular dependency.
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 4, 2021
@annieyw annieyw merged commit dacd4d5 into angular:master Feb 5, 2021
annieyw pushed a commit that referenced this pull request Feb 5, 2021
Moves an interface in order to resolve a circular dependency.

(cherry picked from commit dacd4d5)
annieyw pushed a commit that referenced this pull request Feb 5, 2021
Moves an interface in order to resolve a circular dependency.

(cherry picked from commit dacd4d5)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
Moves an interface in order to resolve a circular dependency.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
Moves an interface in order to resolve a circular dependency.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants