Skip to content

refactor(material/list): remove deprecated APIs for v12 #21974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Cleans up the deprecated APIs for v12 from the material/list package.

BREAKING CHANGES:

  • The mat-list-item-avatar CSS class has been replaced with mat-list-item-with-avatar.
  • MatSelectionListChange.option has been removed. Use MatSelectionListChange.options instead.
  • MatListItemHarnessBase.getHarnessLoaderForContent has been removed. Use
    MatListItemHarnessBase.getChildLoader(MatListItemSection.CONTENT) instead.
  • The tabIndex input has been removed from MatSelectionList.
  • The MatSelectionList constructor has been changed to remove the tabIndex parameter and to turn _focusMonitor into a required parameter.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Feb 21, 2021
@crisbeto crisbeto added this to the 12.0.0 milestone Feb 21, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 21, 2021
@crisbeto crisbeto force-pushed the list-v12-breaking-changes branch from 0dadd7a to 442f335 Compare February 21, 2021 12:37
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Feb 22, 2021
@crisbeto crisbeto force-pushed the list-v12-breaking-changes branch from 442f335 to be6d19c Compare February 26, 2021 17:37
@crisbeto crisbeto force-pushed the list-v12-breaking-changes branch from be6d19c to 62bc925 Compare March 13, 2021 16:29
Cleans up the deprecated APIs for v12 from the `material/list` package.

BREAKING CHANGES:
* The `mat-list-item-avatar` CSS class has been replaced with `mat-list-item-with-avatar`.
* `MatSelectionListChange.option` has been removed. Use `MatSelectionListChange.options` instead.
* `MatListItemHarnessBase.getHarnessLoaderForContent` has been removed. Use
`MatListItemHarnessBase.getChildLoader(MatListItemSection.CONTENT)` instead.
* The `tabIndex` input has been removed from `MatSelectionList`.
* The `MatSelectionList` constructor has been changed to remove the `tabIndex` parameter and to
turn `_focusMonitor` into a required parameter.
@crisbeto crisbeto force-pushed the list-v12-breaking-changes branch from 62bc925 to d258915 Compare April 10, 2021 10:39
@crisbeto crisbeto closed this May 5, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants