fix(material-experimental/mdc-button): remove unthemed icon color #22281
Conversation
google-cla
bot
added
the
cla: yes
andrewseguin
added
G
| @@ -316,13 +316,6 @@ $mat-fab-state-target: '.mdc-fab__ripple'; | |||
| @include mdc-ripple-theme.states( | |||
| $query: mdc-helpers.$mat-theme-styles-query, $ripple-target: $mat-button-state-target); | |||
|
|
|||
| &.mat-unthemed { | |||
There was a problem hiding this comment.
Seems like this was added by you in #16986. I don't remember the context, but maybe there was a specific reason for it? If that's not the case, should we remove the class binding as well?
There was a problem hiding this comment.
All the buttons apply MDC's purple color by default, except for the icon button which has color: inherit. In the other cases, they do need this "unthemed" style to make sure they override the purple. I think this is to just make sure the spec is matched since icon buttons show up on the toolbar, but other buttons don't
andrewseguin
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Icon buttons already have a
color: inheritwhich works well for the unthemed case, specifically it helps adapt it to colored backgrounds, e.g. mat-toolbar