fix(material/table): switch back to class-based styling for flex tables #22350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
|
Caretaker note: these changes will increase the specificity of some selectors which can break people's style overrides. We should determine whether to move forward with the fix based on the amount of breakages in g3. |
In an earlier PR we switched the flex-based table styles to target the tag names, rather than classes in order to support flex tables in MDC. The problem with targeting tag names is that it doesn't allow our styles to be applied to other elements within the table. E.g. in angular#22349 the user isn't able to target the "no data" row. These changes switch back to targeting classes and add some styles to prevent the flex-specific styles from bleeding into the table-based ones. Fixes angular#22349.
crisbeto
force-pushed
the
22349/table-styling
branch
from
5cb3860 to
18ba520
Compare
andrewseguin
approved these changes
Mar 29, 2021
wagnermaciel
pushed a commit
that referenced
this pull request
Jul 12, 2021
…es (#22350) In an earlier PR we switched the flex-based table styles to target the tag names, rather than classes in order to support flex tables in MDC. The problem with targeting tag names is that it doesn't allow our styles to be applied to other elements within the table. E.g. in #22349 the user isn't able to target the "no data" row. These changes switch back to targeting classes and add some styles to prevent the flex-specific styles from bleeding into the table-based ones. Fixes #22349. (cherry picked from commit c76a09e)
wagnermaciel
added a commit
to wagnermaciel/components
that referenced
this pull request
Jul 16, 2021
…lex tables (angular#22350)" (angular#23151) This reverts commit c76a09e.
wagnermaciel
added a commit
to wagnermaciel/components
that referenced
this pull request
Jul 21, 2021
…lex tables (angular#22350)" This reverts commit 749dcbf.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an earlier PR we switched the flex-based table styles to target the tag names, rather than classes in order to support flex tables in MDC. The problem with targeting tag names is that it doesn't allow our styles to be applied to other elements within the table. E.g. in #22349 the user isn't able to target the "no data" row.
These changes switch back to targeting classes and add some styles to prevent the flex-specific styles from bleeding into the table-based ones.
Fixes #22349.