build: add workaround to support RBE on macOS and windows #22423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
area: build & ci
google-cla
bot
added
the
cla: yes
Adds a workaround for `bazel-toolchains` that allows us to use RBE on macOS or Windows. This no longer works with the recent upgrades to `bazel-toolchains`. t It seems like we can remove this workaround once `bazel-toolchains` supports cross-compilation, or if we start generating the toolchain configurations our own (needs more investigation).
devversion
force-pushed
the
build/fix-rbe-on-macos
branch
from
8f4be3c to
2cc4300
Compare
devversion
added
action: merge
mmalerba
added
merge safe
target: patch
mmalerba
pushed a commit
that referenced
this pull request
Apr 9, 2021
Adds a workaround for `bazel-toolchains` that allows us to use RBE on macOS or Windows. This no longer works with the recent upgrades to `bazel-toolchains`. t It seems like we can remove this workaround once `bazel-toolchains` supports cross-compilation, or if we start generating the toolchain configurations our own (needs more investigation). (cherry picked from commit ff69e19)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a workaround for
bazel-toolchainsthat allows us touse RBE on macOS or Windows. This no longer works with the
recent upgrades to
bazel-toolchains.t
It seems like we can remove this workaround once
bazel-toolchainssupports cross-compilation, or if we start generating the
toolchain configurations our own (needs more investigation).