Skip to content

docs(cdk/testing): copy over doc comments from base class to subclasses #22437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Apr 8, 2021

On our docs site, the docs are not inherited from the base class. This
PR also marks our ProtractorHarnessEnvironment as deprecated

On our docs site, the docs are not inherited from the base class. This
PR also marks our ProtractorHarnessEnvironment as deprecated
@mmalerba mmalerba requested a review from devversion as a code owner April 8, 2021 17:46
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 8, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the CI is failing.

@mmalerba
Copy link
Contributor Author

mmalerba commented Apr 8, 2021

Yuck, I guess adding the more specific method interfaces is technically an API change. I don't think it should affect users though since they're working with the generic TestElement interface

@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Apr 8, 2021
@mmalerba mmalerba requested a review from a team as a code owner April 8, 2021 20:43
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Apr 9, 2021
@mmalerba mmalerba merged commit 4b06b90 into angular:master Apr 12, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants