refactor(material-experimental/mdc-button): reorganize styles and expose all themes #22449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
|
I'm surprised this is the case- it seems like we might want to change |
|
I think Andrew did this intentionally to reduce unused CSS (fab probably isn't used all that often). |
|
Does the migration tool add this automatically? |
|
Which migration tool? The |
|
The internal migration tool does add all 3 themes when you migrate the button component |
crisbeto
added
target: rc
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 21, 2021
Updates all of the remaining docs to go through the new `@use` API instead of `@import`. **Note:** does not include the `mdc-button` readme, because the necessary mixins aren't exported yet. See angular#22449.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 22, 2021
Updates all of the remaining docs to go through the new `@use` API instead of `@import`. **Note:** does not include the `mdc-button` readme, because the necessary mixins aren't exported yet. See angular#22449.
andrewseguin
approved these changes
Apr 27, 2021
andrewseguin
pushed a commit
that referenced
this pull request
Apr 27, 2021
andrewseguin
pushed a commit
that referenced
this pull request
Apr 27, 2021
crisbeto
added
target: patch
…ose all themes When I was setting up the new theming API for MDC, I assumed that the button theme would include the icon button and fab themes as well, but that's not the case. These changes reorganize the button theming styles into separate files so that we can easily expose the missing mixins under the correct prefix.
andrewseguin
pushed a commit
that referenced
this pull request
May 19, 2021
…ose all themes (#22449) When I was setting up the new theming API for MDC, I assumed that the button theme would include the icon button and fab themes as well, but that's not the case. These changes reorganize the button theming styles into separate files so that we can easily expose the missing mixins under the correct prefix. (cherry picked from commit ba06cd8)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was setting up the new theming API for MDC, I assumed that the button theme would include the icon button and fab themes as well, but that's not the case.
These changes reorganize the button theming styles into separate files so that we can easily expose the missing mixins under the correct prefix.