fix(material/paginator): add role="group" to host
#22512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
approved these changes
Apr 19, 2021
annieyw
approved these changes
Apr 20, 2021
In testing `<mat-paginator>` with VoiceOver, I found that the interaction was much nicer when the paginator controls were semantically grouped with `role="group"`. This change adds the role and updates the documentation to explicitly instruct users to apply a meaningful label.
jelbourn
force-pushed
the
paginator-group
branch
from
299fa57 to
a282188
Compare
|
Added a test Caretaker note: when this is synced into Google, we should communicate the change to users |
jelbourn
added
merge: caretaker note
|
LGTM |
annieyw
pushed a commit
that referenced
this pull request
May 4, 2021
In testing `<mat-paginator>` with VoiceOver, I found that the interaction was much nicer when the paginator controls were semantically grouped with `role="group"`. This change adds the role and updates the documentation to explicitly instruct users to apply a meaningful label. (cherry picked from commit f06ff2a)
annieyw
pushed a commit
that referenced
this pull request
May 4, 2021
In testing `<mat-paginator>` with VoiceOver, I found that the interaction was much nicer when the paginator controls were semantically grouped with `role="group"`. This change adds the role and updates the documentation to explicitly instruct users to apply a meaningful label. (cherry picked from commit f06ff2a)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing
<mat-paginator>with VoiceOver, I found that the interaction was much nicer when the paginator controls were semantically grouped withrole="group". This change adds the role and updates the documentation to explicitly instruct users to apply a meaningful label.I was on the fence about adding a default label (something like "Pagination control"). I settled on this approach because it's the most consistent with our other controls that require developers to specify a label for host elements, even though we do have
MatPaginatorIntlfor the labels for child components within the control.