refactor: change the toolkit directive prefixes and remove Md prefix from toolkit classes #2258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@jelbourn I still have some doubts:
|
|
@crisbeto It would be good to rename the associated scss variables, but that's not as important. |
|
Renamed the SASS variables and removed the overlay's dependency on theming @jelbourn. This should be good to go. |
…from toolkit classes Renames the the component toolkit to use the `cdk-` prefix, in addition to removing the `Md` prefix from classes associated with the toolkit. The following CSS classes have been renamed as well: * `md-global-overlay-wrapper` -> `cdk-global-overlay-wrapper` * `md-overlay-container` -> `cdk-overlay-container` * `md-overlay-pane` -> `cdk-overlay-pane` * `md-overlay-backdrop-showing` -> `cdk-overlay-backdrop-showing` * `md-overlay-dark-backdrop` -> `cdk-overlay-dark-backdrop` * `md-overlay-backdrop` -> `cdk-overlay-backdrop` * `md-visually-hidden` -> `cdk-visually-hidden`
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the the component toolkit to use the
cdk-prefix, in addition to removing theMdprefix from classes associated with the toolkit.The following CSS classes have been renamed as well:
md-global-overlay-wrapper->cdk-global-overlay-wrappermd-overlay-container->cdk-overlay-containermd-overlay-pane->cdk-overlay-panemd-overlay-backdrop-showing->cdk-overlay-backdrop-showingmd-overlay-dark-backdrop->cdk-overlay-dark-backdropmd-overlay-backdrop->cdk-overlay-backdropmd-visually-hidden->cdk-visually-hidden