build: fix size-test integration tooling #22619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the size integration tests do not run in a blocking way on CI, we should ensure they can be run and do not fail. The tests are still useful for local debugging and comparisons. This commit fixes that NodeJS throws about `webpack` not being found. The build optimizer imports from webpack if we go through the public entry-point. Also simplifies the logic for finding the `angular_ivy_enabled.js` file.
devversion
added
merge safe
area: build & ci
google-cla
bot
added
the
cla: yes
annieyw
pushed a commit
that referenced
this pull request
May 4, 2021
Even though the size integration tests do not run in a blocking way on CI, we should ensure they can be run and do not fail. The tests are still useful for local debugging and comparisons. This commit fixes that NodeJS throws about `webpack` not being found. The build optimizer imports from webpack if we go through the public entry-point. Also simplifies the logic for finding the `angular_ivy_enabled.js` file. (cherry picked from commit b111d4f)
annieyw
pushed a commit
that referenced
this pull request
May 4, 2021
Even though the size integration tests do not run in a blocking way on CI, we should ensure they can be run and do not fail. The tests are still useful for local debugging and comparisons. This commit fixes that NodeJS throws about `webpack` not being found. The build optimizer imports from webpack if we go through the public entry-point. Also simplifies the logic for finding the `angular_ivy_enabled.js` file. (cherry picked from commit b111d4f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the size integration tests do not run
in a blocking way on CI, we should ensure they
can be run and do not fail. The tests are still
useful for local debugging and comparisons.
This commit fixes that NodeJS throws about
webpacknot being found. The build optimizer imports from webpack
if we go through the public entry-point. Also simplifies the
logic for finding the
angular_ivy_enabled.jsfile.