Skip to content

Revert "docs(material/table): use declarative idiomatic RxJS in table-http-example" #22725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2021

Conversation

andrewseguin
Copy link
Contributor

Reverts #22053

The change produced a ExpressionChangedAfterItHasBeenCheckedError because it is setting a template value in ngAfterViewInit.

It's difficult to produce an example for this without subscribe because we need to wait until after the view is set up to retrieve the values we need to provide to the table.

@andrewseguin andrewseguin requested a review from Splaktar May 19, 2021 13:22
@andrewseguin andrewseguin requested a review from a team as a code owner May 19, 2021 13:22
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 19, 2021
@andrewseguin andrewseguin added merge safe P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels May 19, 2021
@andrewseguin andrewseguin requested review from crisbeto and jelbourn May 19, 2021 14:45
@josephperrott josephperrott removed the request for review from a team May 19, 2021 15:14
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 19, 2021
@andrewseguin andrewseguin merged commit 9295ce5 into master May 19, 2021
andrewseguin added a commit that referenced this pull request May 19, 2021
…-http-example (#22053)" (#22725)

This reverts commit 67dc1fd.

(cherry picked from commit 9295ce5)
@Splaktar
Copy link
Contributor

The change produced a ExpressionChangedAfterItHasBeenCheckedError because it is setting a template value in ngAfterViewInit.

Is there an associated issue or reproduction?

@crisbeto
Copy link
Member

You can see it locally in the dev app. It won't happen in the docs, because they're run in production mode.

Splaktar added a commit to DevIntent/components that referenced this pull request Jun 5, 2021
…in table-http-example (angular#22053)" (angular#22725)"

- this reverts commit 9295ce5
- add `detectChanges()` call to fix `NG0100: ExpressionChangedAfterItHasBeenCheckedError`
@Splaktar Splaktar deleted the revert-22053-table-http-no-subscribe branch June 5, 2021 15:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants