Skip to content

docs: add example for using chip-list with form control #22814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2021

Conversation

devversion
Copy link
Member

This clarifies how a chip-list can be used with a form control.
It highlights how a chip list can be disabled. The form control
is placed on the chip input is some cases while it should be
on the chip list, as otherwise the disabled styling does not
apply to the containing form field.

Fixes #19118.

This clarifies how a chip-list can be used with a form control.
It highlights how a chip list can be disabled. The form control
is placed on the chip input is some cases while it should be
on the chip list, as otherwise the disabled styling does not
apply to the containing form field.

Fixes angular#19118.
@devversion devversion added docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels May 26, 2021
@devversion devversion requested a review from mmalerba May 26, 2021 17:10
@devversion devversion requested a review from andrewseguin as a code owner May 26, 2021 17:10
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 26, 2021
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label May 26, 2021
@mmalerba mmalerba merged commit a59aaa3 into angular:master May 26, 2021
mmalerba pushed a commit that referenced this pull request May 26, 2021
This clarifies how a chip-list can be used with a form control.
It highlights how a chip list can be disabled. The form control
is placed on the chip input is some cases while it should be
on the chip list, as otherwise the disabled styling does not
apply to the containing form field.

Fixes #19118.

(cherry picked from commit a59aaa3)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: clarify form control usage in form-field w/ chip-list and chip-input
2 participants