Skip to content

docs(material/form-field): update documentation about the form-field appearances #22817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2021

Conversation

mmalerba
Copy link
Contributor

fixes #20663

@mmalerba mmalerba added merge safe target: patch This PR is targeted for the next patch release labels May 26, 2021
@mmalerba mmalerba requested a review from jelbourn May 26, 2021 18:42
@mmalerba mmalerba requested a review from andrewseguin as a code owner May 26, 2021 18:42
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 26, 2021
compared with both the label and input text.

The second important difference is that the `standard`, `fill`, and `outline` appearances do not
input. The `legacy` and `standard` appearances implement an older version of the spec where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The order seems off as someone learning about the appearances. It seems odd to start with the two appearances that don't match the spec. I'd expect these to be mentioned near the bottom in a section about accepted but not supported appearances.

Then again, we default to legacy so shrug. Would be cool to change the default (and probably transform the code into Google to keep supporting legacy as default)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes sense, I just left it in the order I found it, but it would probably be good to switch it

@mmalerba mmalerba force-pushed the ff-appearance-docs branch from b98138b to 0703fda Compare May 26, 2021 20:20
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label May 26, 2021
@mmalerba mmalerba merged commit a0ad9e5 into angular:master May 26, 2021
mmalerba added a commit that referenced this pull request May 26, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form field examples don't set an explicit appearance which is not super discoverable
3 participants