docs(material/datepicker): clarify moment adapter package #22820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
docs
google-cla
bot
added
the
cla: yes
mmalerba
reviewed
May 26, 2021
| @@ -351,7 +351,7 @@ The easiest way to ensure this is to import one of the provided date modules: | |||
| *Please note: `MatNativeDateModule` is based off the functionality available in JavaScript's | |||
| native [`Date` object](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Date). | |||
| Thus it is not suitable for many locales. One of the biggest shortcomings of the native `Date` | |||
| object is the inability to set the parse format. We highly recommend using the `MomentDateAdapter` | |||
| object is the inability to set the parse format. You can use the `MomentDateAdapter` | |||
There was a problem hiding this comment.
The thing is we also don't recommend the NativeDateAdapter. Should we add something about what we do recommend? (Which I guess currently is to just write your own 😬)
There was a problem hiding this comment.
Updated the text to strong recommend anything but the native adapter, with moment and other being possible options.
Clarifies that the moment date adapter lives in its own npm package. Also removes language about _recommending_ the moment adapter. Fixes angular#18539
jelbourn
force-pushed
the
date-adapter-package-install
branch
from
666a3ad to
d26b2cb
Compare
mmalerba
approved these changes
May 28, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies that the moment date adapter lives in its own npm package.
Also removes language about recommending the moment adapter.
Fixes #18539