Revert "fix(material-experimental/mdc-button): set proper touch target #22925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular#22846)" This reverts commit 793e1f1.
google-cla
bot
added
the
cla: yes
andrewseguin
added
the
target: patch
crisbeto
approved these changes
Jun 9, 2021
andrewseguin
added a commit
that referenced
this pull request
Jun 9, 2021
crisbeto
added a commit
to crisbeto/material-components-web
that referenced
this pull request
Jun 9, 2021
Currently the `touch-target` mixin produces styles that will set the touch target outside of the host node on RTL layouts (see angular/components#22925). These changes adjust the styles so that the target is always centered.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 793e1f1.
This has to be reverted from Google because the RTL icon buttons are breaking layout. See screenshot where there an outline around the touch targets.
Looks like we need to switch the transform to
transform: translate(50%, -50%)in RTL