Skip to content

test(multiple): refactor unit tests of several components #22952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nitinmalave
Copy link
Contributor

Opening this PR as it is required to:

  • Refactor variables in various component unit tests to have constant type instead of let as this variables are not getting re-initialize during the test life-time.
  • Added type annotations to variables instead of any.
  • Renamed variables.
  • All tests within a spec should be consistent with all other tests in repo.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 10, 2021
@nitinmalave nitinmalave force-pushed the refactor-dialog-component-unit-tests branch from 67e253c to e16fd9c Compare June 10, 2021 20:09
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but the commit title needs to be updated to say test(multiple instead of test(material/multiple).

@nitinmalave nitinmalave changed the title test(material/multiple): refactor unit tests of several components test(multiple): refactor unit tests of several components Jun 11, 2021
@nitinmalave nitinmalave force-pushed the refactor-dialog-component-unit-tests branch from e16fd9c to 6079480 Compare June 11, 2021 05:37
@nitinmalave
Copy link
Contributor Author

Fixed it.

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Jun 11, 2021
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work 🎉

@wagnermaciel wagnermaciel merged commit 30cfd7d into angular:master Jun 11, 2021
wagnermaciel pushed a commit that referenced this pull request Jun 11, 2021
@nitinmalave nitinmalave deleted the refactor-dialog-component-unit-tests branch June 12, 2021 06:40
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants