-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/datepicker): add focus indication for selected date #22972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Currently there's no way to tell when the selected date in the calendar has focus. These changes reuse the styling from when the selected date is today (white circle inside the main circle). Fixes angular#22883.
Caretaker note: this will likely cause some screenshot diffs, because focus lands on the selected date automatically when the calendar is opened. As long as the screenshot diff only shows a slight circle inside the selected date, it should be fine. |
I'm not sure using the same styles as selected & today makes sense. What happens then when today is selected & focused? |
It'll look exactly like it does at the moment, because we don't have focus indication for the selected date right now. It's not ideal, but it's still an improvement over what we have now. The alternative would be to use a different background color if a date is selected and focused, but the current selected color is already very bright so we may have to make it darker which won't look good, IMO. |
Would be good to take a look at this again, the expected behavior was working in v12, but has since broken in v13 and v14 |
Currently there's no way to tell when the selected date in the calendar has focus. These changes reuse the styling from when the selected date is today (white circle inside the main circle).
Fixes #22883.