Skip to content

build: run unit tests with partial compilation and Angular linker #22979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Instead of running e2e tests against a linker-processed application, we
run all of our unit tests using partial compilation and the Angular
linker. This ensures we test our components more throroughly against
the Angular linker & partial compilation. This also solves our CI
flakiness issue due to the large amount of webdriver e2e tests running
concurrently on CI (especially since all e2e tests ran on snapshot
builds).

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 15, 2021
@devversion devversion force-pushed the build/run-unit-tests-with-linker branch 4 times, most recently from 6c8c9b2 to 914ee3d Compare June 15, 2021 19:06
@devversion devversion marked this pull request as ready for review June 15, 2021 19:06
@devversion devversion requested review from jelbourn and a team as code owners June 15, 2021 19:06
@devversion devversion requested a review from josephperrott June 15, 2021 19:06
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Jun 15, 2021
@devversion devversion requested a review from crisbeto June 15, 2021 19:19
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I don't have a lot of context on the Bazel code.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Instead of running e2e tests against a linker-processed application, we
run all of our unit tests using partial compilation and the Angular
linker. This ensures we test our components more throroughly against
the Angular linker & partial compilation. This also solves our CI
flakiness issue due to the large amount of webdriver e2e tests running
concurrently on CI (especially since all e2e tests ran on snapshot
builds).
@devversion devversion force-pushed the build/run-unit-tests-with-linker branch from 914ee3d to 5cb77af Compare June 16, 2021 18:20
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 16, 2021
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 77e5c21 into angular:master Jun 18, 2021
mmalerba pushed a commit that referenced this pull request Jun 18, 2021
…2979)

Instead of running e2e tests against a linker-processed application, we
run all of our unit tests using partial compilation and the Angular
linker. This ensures we test our components more throroughly against
the Angular linker & partial compilation. This also solves our CI
flakiness issue due to the large amount of webdriver e2e tests running
concurrently on CI (especially since all e2e tests ran on snapshot
builds).

(cherry picked from commit 77e5c21)
mmalerba pushed a commit that referenced this pull request Jun 18, 2021
…2979)

Instead of running e2e tests against a linker-processed application, we
run all of our unit tests using partial compilation and the Angular
linker. This ensures we test our components more throroughly against
the Angular linker & partial compilation. This also solves our CI
flakiness issue due to the large amount of webdriver e2e tests running
concurrently on CI (especially since all e2e tests ran on snapshot
builds).

(cherry picked from commit 77e5c21)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants