-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: run unit tests with partial compilation and Angular linker #22979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: run unit tests with partial compilation and Angular linker #22979
Conversation
6c8c9b2
to
914ee3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I don't have a lot of context on the Bazel code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Instead of running e2e tests against a linker-processed application, we run all of our unit tests using partial compilation and the Angular linker. This ensures we test our components more throroughly against the Angular linker & partial compilation. This also solves our CI flakiness issue due to the large amount of webdriver e2e tests running concurrently on CI (especially since all e2e tests ran on snapshot builds).
914ee3d
to
5cb77af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…2979) Instead of running e2e tests against a linker-processed application, we run all of our unit tests using partial compilation and the Angular linker. This ensures we test our components more throroughly against the Angular linker & partial compilation. This also solves our CI flakiness issue due to the large amount of webdriver e2e tests running concurrently on CI (especially since all e2e tests ran on snapshot builds). (cherry picked from commit 77e5c21)
…2979) Instead of running e2e tests against a linker-processed application, we run all of our unit tests using partial compilation and the Angular linker. This ensures we test our components more throroughly against the Angular linker & partial compilation. This also solves our CI flakiness issue due to the large amount of webdriver e2e tests running concurrently on CI (especially since all e2e tests ran on snapshot builds). (cherry picked from commit 77e5c21)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Instead of running e2e tests against a linker-processed application, we
run all of our unit tests using partial compilation and the Angular
linker. This ensures we test our components more throroughly against
the Angular linker & partial compilation. This also solves our CI
flakiness issue due to the large amount of webdriver e2e tests running
concurrently on CI (especially since all e2e tests ran on snapshot
builds).