-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material-experimental/mdc-tooltip): fix text alignment of multili… #22981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material-experimental/mdc-tooltip): fix text alignment of multili… #22981
Conversation
…ne tooltips * Add the 'mdc-tooltip--multiline' class when a tooltip overflows to make the text align left (or right in rtl) instead of center
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a test for the new code?
Yes, it definitely should. I'll add one today 👍🏽 |
…multiline tooltips
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…multiline tooltips
…multiline tooltips
…s set on tooltips with messages that overflow
…multiline tooltips
…multiline tooltips
#22981) * fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * Add the 'mdc-tooltip--multiline' class when a tooltip overflows to make the text align left (or right in rtl) instead of center * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * test(material-experimental/mdc-tooltip): ensure the multiline class is set on tooltips with messages that overflow * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips (cherry picked from commit 81cd26b)
#22981) * fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * Add the 'mdc-tooltip--multiline' class when a tooltip overflows to make the text align left (or right in rtl) instead of center * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * test(material-experimental/mdc-tooltip): ensure the multiline class is set on tooltips with messages that overflow * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips (cherry picked from commit 81cd26b)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…ne tooltips
to make the text align left (or right in rtl) instead of center