Skip to content

docs: improve paginator-intl example #22988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

We recently added a new example for paginator with internationalization.
For testing, the paginator has been set to length = 0. The example
paginator should have some items so that the various labels can be
seen in the paginator (currently there are no pages to iterate through).

We recently added a new example for paginator with internationalization.
For testing, the paginator has been set to `length = 0`. The example
paginator should have some items so that the various labels can be
seen in the paginator (currently there are no pages to iterate through).
@devversion devversion added docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Jun 15, 2021
@devversion devversion requested a review from crisbeto June 15, 2021 20:49
@devversion devversion requested a review from andrewseguin as a code owner June 15, 2021 20:49
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 15, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 16, 2021
@mmalerba mmalerba merged commit 4531748 into angular:master Jun 18, 2021
mmalerba pushed a commit that referenced this pull request Jun 18, 2021
We recently added a new example for paginator with internationalization.
For testing, the paginator has been set to `length = 0`. The example
paginator should have some items so that the various labels can be
seen in the paginator (currently there are no pages to iterate through).

(cherry picked from commit 4531748)
mmalerba pushed a commit that referenced this pull request Jun 18, 2021
We recently added a new example for paginator with internationalization.
For testing, the paginator has been set to `length = 0`. The example
paginator should have some items so that the various labels can be
seen in the paginator (currently there are no pages to iterate through).

(cherry picked from commit 4531748)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants