Skip to content

build: allow for some schematics code to be linted #23006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2021
Merged

build: allow for some schematics code to be linted #23006

merged 1 commit into from
Jun 18, 2021

Conversation

crisbeto
Copy link
Member

The linting setup was excluding all of the code under schematics/test-cases, however we only need to do it for the _input and _expected_output files.

These changes allow the files to be linted and fixes some errors that went undetected.

@crisbeto
build: allow for some schematics code to be linted
1193c80 
The linting setup was excluding all of the code under `schematics/test-cases`, however we only need to do it for the `_input` and `_expected_output` files.

These changes allow the files to be linted and fixes some errors that went undetected.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Jun 17, 2021
@crisbeto crisbeto requested a review from devversion June 17, 2021 15:34
@crisbeto crisbeto requested review from jelbourn and a team as code owners June 17, 2021 15:34
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 17, 2021
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 17, 2021
jelbourn
jelbourn approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 18, 2021
@mmalerba mmalerba merged commit 17667b8 into angular:master Jun 18, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @mmalerba