refactor(material-experimental/mdc-tooltip): add override keyword to satisfy noImplicitOverride check #23017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…satisfy noImplicitOverride Given we merged the `noImplicitOverride` PR together with a couple of other PRs, new methods could have been introduced that did not use the `override` keyword. This is the case for the MDC tooltip `_onShow` method. This commit adds the necessary `override` keyword.
google-cla
bot
added
the
cla: yes
devversion
added
the
target: minor
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Jun 29, 2021
…satisfy noImplicitOverride (angular#23017) Given we merged the `noImplicitOverride` PR together with a couple of other PRs, new methods could have been introduced that did not use the `override` keyword. This is the case for the MDC tooltip `_onShow` method. This commit adds the necessary `override` keyword.
amysorto
pushed a commit
that referenced
this pull request
Jun 30, 2021
…satisfy noImplicitOverride (#23017) Given we merged the `noImplicitOverride` PR together with a couple of other PRs, new methods could have been introduced that did not use the `override` keyword. This is the case for the MDC tooltip `_onShow` method. This commit adds the necessary `override` keyword.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…satisfy noImplicitOverride
Given we merged the
noImplicitOverridePR together with a couple ofother PRs, new methods could have been introduced that did not use
the
overridekeyword. This is the case for the MDC tooltip_onShowmethod. This commit adds the necessary
overridekeyword.