fix(cdk/drag-drop): resolve various event tracking issues inside the shadow dom #23026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
…shadow dom The `drag-drop` module depends on a single document-level `scroll` listener in order to adjust itself when the page or an element is scrolled. The problem is that the events won't be picked up if they come from inside a shadow root. These changes add some logic to bind an extra event at the shadow root level. Furthermore, they fix several places where we were reading the `Event.target` while not accounting for shadow DOM. Fixes angular#22939.
crisbeto
force-pushed
the
22939/drag-drop-scroll-tracking-shadow-dom
branch
from
7d62df1 to
f35d9a7
Compare
mmalerba
pushed a commit
that referenced
this pull request
Jun 22, 2021
…shadow dom (#23026) The `drag-drop` module depends on a single document-level `scroll` listener in order to adjust itself when the page or an element is scrolled. The problem is that the events won't be picked up if they come from inside a shadow root. These changes add some logic to bind an extra event at the shadow root level. Furthermore, they fix several places where we were reading the `Event.target` while not accounting for shadow DOM. Fixes #22939. (cherry picked from commit bd08e93)
mmalerba
pushed a commit
that referenced
this pull request
Jun 22, 2021
…shadow dom (#23026) The `drag-drop` module depends on a single document-level `scroll` listener in order to adjust itself when the page or an element is scrolled. The problem is that the events won't be picked up if they come from inside a shadow root. These changes add some logic to bind an extra event at the shadow root level. Furthermore, they fix several places where we were reading the `Event.target` while not accounting for shadow DOM. Fixes #22939. (cherry picked from commit bd08e93)
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 29, 2021
A recent change (angular#23026) appears to have introduced flakiness in our unit tests on Firefox. These changes apply a similar workaround to some of the other scrolling tests.
amysorto
pushed a commit
that referenced
this pull request
Jun 29, 2021
A recent change (#23026) appears to have introduced flakiness in our unit tests on Firefox. These changes apply a similar workaround to some of the other scrolling tests.
amysorto
pushed a commit
that referenced
this pull request
Jun 29, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
drag-dropmodule depends on a single document-levelscrolllistener in order to adjust itself when the page or an element is scrolled. The problem is that the events won't be picked up if they come from inside a shadow root.These changes add some logic to bind an extra event at the shadow root level. Furthermore, they fix several places where we were reading the
Event.targetwhile not accounting for shadow DOM.Fixes #22939.