Skip to content

fix(material-experimental/mdc-list): support noop animations #23117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2021
Merged

fix(material-experimental/mdc-list): support noop animations #23117

merged 1 commit into from
Jul 9, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 6, 2021

Fixes that the list animations weren't being disabled with the NoopAnimationsModule.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 6, 2021
@crisbeto crisbeto requested a review from devversion July 6, 2021 05:47
@crisbeto crisbeto requested a review from mmalerba as a code owner July 6, 2021 05:47
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 6, 2021
devversion
devversion approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor nit

@crisbeto
fix(material-experimental/mdc-list): support noop animations
e9eceed 
Fixes that the list animations weren't being disabled with the `NoopAnimationsModule`.
@crisbeto crisbeto force-pushed the mdc-list-noop-animations branch from bfe8184 to e9eceed Compare July 6, 2021 18:30
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 6, 2021
@wagnermaciel wagnermaciel merged commit e1d775d into angular:master Jul 9, 2021
wagnermaciel pushed a commit that referenced this pull request Jul 9, 2021
@crisbeto @wagnermaciel
fix(material-experimental/mdc-list): support noop animations (#23117)
279461c 
Fixes that the list animations weren't being disabled with the `NoopAnimationsModule`.

(cherry picked from commit e1d775d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @devversion @wagnermaciel