Skip to content

fix(material/core): handle hues inferred as numbers #23237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2021
Merged

fix(material/core): handle hues inferred as numbers #23237

merged 1 commit into from
Aug 4, 2021

Conversation

crisbeto
Copy link
Member

We have some hues that start with a number (e.g. 700-contrast), which can break the map lookup in get-color-from-palette, because Sass infers them as numbers.

These changes make it so that the key is cast to a string before we do the lookup.

Fixes #23230.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 23, 2021
@crisbeto crisbeto requested a review from jelbourn July 23, 2021 19:24
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 23, 2021
@crisbeto crisbeto mentioned this pull request Jul 26, 2021
Closed
@crisbeto crisbeto force-pushed the 23230/theme-lookup branch from d1210d8 to 8d4e79c Compare July 26, 2021 06:01
@crisbeto
fix(material/core): handle hues inferred as numbers
a691819 
We have some hues that start with a number (e.g. `700-contrast`), which can break the map lookup in `get-color-from-palette`, because Sass infers them as numbers.

These changes make it so that the key is cast to a string before we do the lookup.

Fixes angular#23230.
@crisbeto crisbeto force-pushed the 23230/theme-lookup branch from 8d4e79c to a691819 Compare July 26, 2021 17:15
jelbourn
jelbourn approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jul 30, 2021
@zarend zarend merged commit df7c46b into angular:master Aug 4, 2021
zarend pushed a commit that referenced this pull request Aug 4, 2021
@crisbeto @zarend
fix(material/core): handle hues inferred as numbers (#23237)
dbb7226 
We have some hues that start with a number (e.g. `700-contrast`), which can break the map lookup in `get-color-from-palette`, because Sass infers them as numbers.

These changes make it so that the key is cast to a string before we do the lookup.

Fixes #23230.

(cherry picked from commit df7c46b)
zarend pushed a commit that referenced this pull request Aug 4, 2021
@crisbeto @zarend
fix(material/core): handle hues inferred as numbers (#23237)
a752641 
We have some hues that start with a number (e.g. `700-contrast`), which can break the map lookup in `get-color-from-palette`, because Sass infers them as numbers.

These changes make it so that the key is cast to a string before we do the lookup.

Fixes #23230.

(cherry picked from commit df7c46b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mat.get-color-from-palette not working for contrast values
3 participants
@crisbeto @jelbourn @zarend