Skip to content

feat(cdk/overlay): Extend cdkConnectedOverlayOrigin to support more types. #23253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2021
Merged

feat(cdk/overlay): Extend cdkConnectedOverlayOrigin to support more types. #23253

merged 1 commit into from
Jul 30, 2021

Conversation

ienzam
Copy link
Contributor

@ienzam ienzam commented Jul 27, 2021

CdkConnectedOverlay directive's input cdkConnectedOverlayOrigin only supports CdkOverlayOrigin.
FlexibleConnectedPositionStrategy supports a lot more types. Add support for them.

Fixes #23252

@ienzam ienzam requested review from crisbeto and jelbourn as code owners July 27, 2021 22:30
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 27, 2021
@ienzam ienzam force-pushed the fix_23252_flexible_cdkConnectedOverlayOrigin branch from 02dfcc6 to 217ac0d Compare July 27, 2021 23:36
crisbeto
crisbeto reviewed Jul 28, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also have to run yarn approve-api overlay to fix the API golden failure.

@ienzam ienzam force-pushed the fix_23252_flexible_cdkConnectedOverlayOrigin branch from 217ac0d to c351d1e Compare July 28, 2021 17:22
@ienzam ienzam requested a review from a team as a code owner July 28, 2021 17:22
@ienzam ienzam force-pushed the fix_23252_flexible_cdkConnectedOverlayOrigin branch from c351d1e to cd28f52 Compare July 28, 2021 17:43
crisbeto
crisbeto reviewed Jul 28, 2021
View reviewed changes
@ienzam
feat(cdk/overlay): Extend cdkConnectedOverlayOrigin to support more…
bf6f74b 
… types.

`CdkConnectedOverlay` directive's input `cdkConnectedOverlayOrigin` only supports `CdkOverlayOrigin`.
`FlexibleConnectedPositionStrategy` supports a lot more types. Add support for them.

Fixes angular#23252
@ienzam ienzam force-pushed the fix_23252_flexible_cdkConnectedOverlayOrigin branch from cd28f52 to bf6f74b Compare July 28, 2021 17:59
crisbeto
crisbeto approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Jul 28, 2021
@zarend
Copy link
Contributor

zarend commented Jul 30, 2021

presubmit (internal). Tests ran last night with about 100 failures, many of them are timeouts.

@zarend zarend added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Jul 30, 2021
@zarend
Copy link
Contributor

zarend commented Jul 30, 2021

presubmit (internal). Tests ran last night with about 100 failures, many of them are timeouts.

tests passed on re-run

@zarend zarend removed the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Jul 30, 2021
@zarend zarend merged commit 51796e1 into angular:master Jul 30, 2021
@ienzam
Copy link
Contributor Author

ienzam commented Jul 30, 2021

Thanks for the reviews and merging!

@ienzam ienzam deleted the fix_23252_flexible_cdkConnectedOverlayOrigin branch July 30, 2021 22:13
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(CdkConnectedOverlay): Extend cdkConnectedOverlayOrigin input to support FlexibleConnectedPositionStrategyOrigin
3 participants
@ienzam @zarend @crisbeto