fix(cdk/overlay): expand OverlayReference interface to cover more properties
#23254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
…roperties We have an interface called `OverlayReference` which is meant to mimic `OverlayRef` while allowing us to break the circular dependency of `ScrollStrategy -> OverlayRef -> OverlayConfig -> ScrollStrategy`. The problem is that it currently doesn't expose some useful members. These changes expand the interface to cover more of the `OverlayRef` API surface. Fixes angular#23234.
crisbeto
force-pushed
the
23234/overlay-ref-interface
branch
from
923631d to
fb54ce6
Compare
zarend
pushed a commit
that referenced
this pull request
Aug 4, 2021
…roperties (#23254) We have an interface called `OverlayReference` which is meant to mimic `OverlayRef` while allowing us to break the circular dependency of `ScrollStrategy -> OverlayRef -> OverlayConfig -> ScrollStrategy`. The problem is that it currently doesn't expose some useful members. These changes expand the interface to cover more of the `OverlayRef` API surface. Fixes #23234. (cherry picked from commit 357c396)
zarend
pushed a commit
that referenced
this pull request
Aug 4, 2021
…roperties (#23254) We have an interface called `OverlayReference` which is meant to mimic `OverlayRef` while allowing us to break the circular dependency of `ScrollStrategy -> OverlayRef -> OverlayConfig -> ScrollStrategy`. The problem is that it currently doesn't expose some useful members. These changes expand the interface to cover more of the `OverlayRef` API surface. Fixes #23234. (cherry picked from commit 357c396)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an interface called
OverlayReferencewhich is meant to mimicOverlayRefwhile allowing us to break the circular dependency ofScrollStrategy -> OverlayRef -> OverlayConfig -> ScrollStrategy. The problem is that it currently doesn't expose some useful members.These changes expand the interface to cover more of the
OverlayRefAPI surface.Fixes #23234.