Skip to content

build: flag unnecessary stylelint disable clauses #23290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2021
Merged

build: flag unnecessary stylelint disable clauses #23290

merged 1 commit into from
Aug 2, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 1, 2021

Bumps Stylelint to the latest version and turns on an option to flag unnecessary disable clauses.

@crisbeto
build: flag unnecessary stylelint disable clauses
267ef5b 
Bumps Stylelint to the latest version and turns on an option to flag unnecessary disable clauses.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Aug 1, 2021
@crisbeto crisbeto requested a review from devversion August 1, 2021 18:55
@crisbeto crisbeto requested review from mmalerba and a team as code owners August 1, 2021 18:55
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 1, 2021
mmalerba
mmalerba approved these changes Aug 1, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 1, 2021
@zarend zarend added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 2, 2021
@zarend zarend merged commit 57a01bf into angular:master Aug 2, 2021
@zarend
Copy link
Contributor

zarend commented Aug 2, 2021

I am unable to merge this into patch because of merge conflicts with 12.1.x, so I changed the target to minor.

@crisbeto does this need to go into patch too?

@crisbeto
Copy link
Member Author

crisbeto commented Aug 3, 2021

It just needs to go into master.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @zarend @mmalerba