Skip to content

refactor(cdk/a11y): clean up IE workarounds #23304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2021
Merged

refactor(cdk/a11y): clean up IE workarounds #23304

merged 1 commit into from
Aug 18, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 4, 2021

Cleans up the workarounds for IE11 from the cdk/a11y package.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Aug 4, 2021
@crisbeto crisbeto requested a review from jelbourn August 4, 2021 15:34
@crisbeto crisbeto requested a review from devversion as a code owner August 4, 2021 15:34
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 4, 2021
@crisbeto
refactor(cdk/a11y): clean up IE workarounds
0f7ae91 
Cleans up the workarounds for IE11 from the `cdk/a11y` package.
jelbourn
jelbourn approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Aug 5, 2021
@jelbourn
Copy link
Member

jelbourn commented Aug 5, 2021

Changed to target: major

@wagnermaciel wagnermaciel merged commit e82ff91 into angular:master Aug 18, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @wagnermaciel