Skip to content

build: update peer dependency for angular framework dependencies #23307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2021
Merged

build: update peer dependency for angular framework dependencies #23307

merged 1 commit into from
Aug 4, 2021

Conversation

devversion
Copy link
Member

The release tool will require us to update the peer dependencies to no longer
allow for v12 when cutting v13 major pre-releases.

@devversion
build: update peer dependency for angular framework dependencies
ac0b162 
The release tool will require us to update the peer dependencies to no longer
allow for v12 when cutting v13 major pre-releases.
@devversion devversion added merge safe target: major This PR is targeted for the next major release labels Aug 4, 2021
@devversion devversion requested a review from zarend August 4, 2021 18:49
@devversion devversion requested a review from a team as a code owner August 4, 2021 18:49
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 4, 2021
josephperrott
josephperrott approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround labels Aug 4, 2021
@zarend zarend merged commit a6e264a into master Aug 4, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2021
@devversion devversion deleted the devversion-patch-1 branch July 4, 2022 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@zarend zarend Awaiting requested review from zarend

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @josephperrott @zarend