Skip to content

release: remote luxon adapter from changelog #23318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2021
Merged

release: remote luxon adapter from changelog #23318

merged 1 commit into from
Aug 5, 2021

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Aug 5, 2021 •
edited
Loading

The luxon adapter didn't go into minor, this updates the CHANGELOG to reflect that.

Using target: patch label so this will go into both the master and 12.2.x branches.

@zarend zarend requested a review from jelbourn August 5, 2021 22:59
@zarend zarend requested a review from a team as a code owner August 5, 2021 22:59
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 5, 2021
@zarend zarend changed the base branch from 12.2.x to master August 5, 2021 23:04
@zarend zarend changed the base branch from master to 12.2.x August 5, 2021 23:04
@zarend zarend force-pushed the update-changelog-12.2.0 branch from 10c05b6 to ab96e49 Compare August 5, 2021 23:05
@zarend zarend requested a review from devversion as a code owner August 5, 2021 23:05
@zarend zarend changed the base branch from 12.2.x to master August 5, 2021 23:05
@zarend zarend force-pushed the update-changelog-12.2.0 branch from ab96e49 to 032a8eb Compare August 5, 2021 23:07
@zarend zarend added target: minor This PR is targeted for the next minor release action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge safe and removed target: minor This PR is targeted for the next minor release labels Aug 5, 2021
jelbourn
jelbourn approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zarend zarend added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Aug 5, 2021
@zarend zarend merged commit 57d8e78 into angular:master Aug 5, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@crisbeto crisbeto Awaiting requested review from crisbeto

@mmalerba mmalerba Awaiting requested review from mmalerba

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zarend @jelbourn