-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/select): error if selected value is accessed too early #23378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wagnermaciel
merged 1 commit into
angular:master
from
crisbeto:23371/select-early-access
Sep 20, 2021
Merged
fix(material/select): error if selected value is accessed too early #23378
wagnermaciel
merged 1 commit into
angular:master
from
crisbeto:23371/select-early-access
Sep 20, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 20, 2021
Similar issue to angular#23378. The chip list will throw an error if the `selected` value is accessed before the selection model has been initialized.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 24, 2021
Similar issue to angular#23378. The chip list will throw an error if the `selected` value is accessed before the selection model has been initialized.
Fixes that the select throws if the `selected` value is accessed before everything is initialized. Fixes angular#23371.
ba03388
to
42152eb
Compare
jelbourn
approved these changes
Aug 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zarend
pushed a commit
that referenced
this pull request
Sep 7, 2021
wagnermaciel
pushed a commit
that referenced
this pull request
Sep 20, 2021
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
PR author has agreed to Google's Contributor License Agreement
G
This is is related to a Google internal issue
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the select throws if the
selected
value is accessed before everything is initialized.Fixes #23371.