fix(material/stepper): remove ripple and hover styling for disabled step #23386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
amysorto
added
Accessibility
crisbeto
reviewed
Aug 17, 2021
| @@ -17,10 +17,14 @@ | |||
| .mat-step-header { | |||
| &.cdk-keyboard-focused, | |||
| &.cdk-program-focused, | |||
| &:hover { | |||
| &:hover:not([aria-disabled]) { | |||
There was a problem hiding this comment.
This will cover aria-disabled="false" as well. Should the selector be more specific?
There was a problem hiding this comment.
Right now we only add the aria-disabled attribute when its equal to true. Although I think being more specific makes sense in case that ever changes
amysorto
force-pushed
the
remove-ripple-and-hover-from-disabled-step
branch
3 times, most recently
from
fb2aac3 to
87909f5
Compare
amysorto
force-pushed
the
remove-ripple-and-hover-from-disabled-step
branch
from
87909f5 to
ac53074
Compare
mmalerba
approved these changes
Aug 18, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.