build: group commits by package name in changelog #23460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
devversion
added
action: merge
devversion
commented
Aug 26, 2021
.ng-dev/release.ts
Outdated
| groupOrder: releasePackages, | ||
| categorizeCommit: commit => { | ||
| const [packageName, entryPointName] = commit.scope.split('/'); | ||
| const entryPointPrefix = entryPointName ? `${entryPointName}: ` : ''; |
There was a problem hiding this comment.
@josephperrott should we make this bold?
There was a problem hiding this comment.
I added it now; I think that is a good thing, and we did it like that before with the legacy tooling as well.
Currently the new release tooling groups changes in the changelog based on their commit scope. This is the default behavior that works well for FW and the CLI repo. For the components repository, we also include secondary entry-point information in commit messages. This currently results in many unnecessary groups, while ideally we'd want to group based on the package name in the scope. This commit implements that.
devversion
force-pushed
the
build-better-changelog-grouping
branch
from
e3d4a17 to
337025f
Compare
mmalerba
pushed a commit
that referenced
this pull request
Aug 31, 2021
Currently the new release tooling groups changes in the changelog based on their commit scope. This is the default behavior that works well for FW and the CLI repo. For the components repository, we also include secondary entry-point information in commit messages. This currently results in many unnecessary groups, while ideally we'd want to group based on the package name in the scope. This commit implements that. (cherry picked from commit 9aa21dc)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the new release tooling groups changes in the
changelog based on their commit scope. This is the default
behavior that works well for FW and the CLI repo.
For the components repository, we also include secondary entry-point
information in commit messages. This currently results in
many unnecessary groups, while ideally we'd want to group
based on the package name in the scope. This commit implements
that.