-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: group commits by package name in changelog #23460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: group commits by package name in changelog #23460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.ng-dev/release.ts
Outdated
groupOrder: releasePackages, | ||
categorizeCommit: commit => { | ||
const [packageName, entryPointName] = commit.scope.split('/'); | ||
const entryPointPrefix = entryPointName ? `${entryPointName}: ` : ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josephperrott should we make this bold?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it now; I think that is a good thing, and we did it like that before with the legacy tooling as well.
Currently the new release tooling groups changes in the changelog based on their commit scope. This is the default behavior that works well for FW and the CLI repo. For the components repository, we also include secondary entry-point information in commit messages. This currently results in many unnecessary groups, while ideally we'd want to group based on the package name in the scope. This commit implements that.
e3d4a17
to
337025f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Currently the new release tooling groups changes in the changelog based on their commit scope. This is the default behavior that works well for FW and the CLI repo. For the components repository, we also include secondary entry-point information in commit messages. This currently results in many unnecessary groups, while ideally we'd want to group based on the package name in the scope. This commit implements that. (cherry picked from commit 9aa21dc)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently the new release tooling groups changes in the
changelog based on their commit scope. This is the default
behavior that works well for FW and the CLI repo.
For the components repository, we also include secondary entry-point
information in commit messages. This currently results in
many unnecessary groups, while ideally we'd want to group
based on the package name in the scope. This commit implements
that.