build: update to nodejs v16 and update rules_nodejs to v4 stable #23485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
merge safe
target: patch
google-cla
bot
added
the
cla: yes
devversion
force-pushed
the
build/m1-compatibility
branch
from
07d6e8f to
e814b09
Compare
devversion
force-pushed
the
build/m1-compatibility
branch
3 times, most recently
from
9726445 to
b21a0ae
Compare
Updates NodeJS to v16 and updates rules_nodejs to v4 stable. This allows developers running tests and building with ARM64 darwin. i.e. Apple Silicon/M1 devices.
devversion
force-pushed
the
build/m1-compatibility
branch
from
b21a0ae to
4523913
Compare
devversion
commented
Aug 29, 2021
| await getElement(otherElement).getLocation().then((location: Point) => { | ||
| expectLocation(getElement(element), location); | ||
| await getElement(otherElement).getLocation().then(async (location: Point) => { | ||
| await expectLocation(getElement(element), location); |
There was a problem hiding this comment.
For some reason there was a missing await here that caused e2e tests to fail. Not sure if it was flaky because it happened constantly on this PR, but the missing await definitely is reasonable for flakiness..
mmalerba
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates NodeJS to v16 and updates rules_nodejs to v4 stable. This
allows developers running tests and building with ARM64 darwin. i.e.
Apple Silicon/M1 devices.